torwig commented on code in PR #2272: URL: https://github.com/apache/kvrocks/pull/2272#discussion_r1584102881
########## src/cluster/cluster.cc: ########## @@ -37,11 +39,11 @@ #include "time_util.h" ClusterNode::ClusterNode(std::string id, std::string host, int port, int role, std::string master_id, - std::bitset<kClusterSlots> slots) + std::bitset<kClusterSlots> const &slots) Review Comment: I think in this project we usually put the `const` qualifier before the type: `const std::bitset<kClusterSlots> &slots` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
