PragmaTwice commented on code in PR #2222:
URL: https://github.com/apache/kvrocks/pull/2222#discussion_r1589910802
##########
src/storage/redis_db.cc:
##########
@@ -309,10 +314,12 @@ rocksdb::Status Database::Keys(const std::string &prefix,
std::vector<std::strin
return rocksdb::Status::OK();
}
-rocksdb::Status Database::Scan(const std::string &cursor, uint64_t limit,
const std::string &prefix,
- std::vector<std::string> *keys, std::string
*end_cursor, RedisType type) {
+rocksdb::Status Database::Scan(const std::string &cursor, uint64_t
scan_success_limit, uint64_t scan_false_limit,
+ const std::string &match_str,
std::vector<std::string> *keys, std::string *end_cursor,
+ RedisType type, const MatchType match_mode) {
Review Comment:
I have some questions about your design.
But before that, could you give a little introduction about your general
design and supported patterns in the PR description?
Then we can have a detailed review on your code.
Refer to Redis glob-style patterns:
>Supported glob-style patterns:
>
>`h?llo` matches hello, hallo and hxllo
`h*llo` matches hllo and heeeello
`h[ae]llo` matches hello and hallo, but not hillo
`h[^e]llo` matches hallo, hbllo, ... but not hello
`h[a-b]llo` matches hallo and hbllo
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
