PragmaTwice commented on code in PR #2296:
URL: https://github.com/apache/kvrocks/pull/2296#discussion_r1597468621
##########
src/storage/storage.h:
##########
@@ -51,31 +51,25 @@ inline constexpr StorageEngineType STORAGE_ENGINE_TYPE =
StorageEngineType::KVRO
const int kReplIdLength = 16;
-enum ColumnFamilyID {
- kColumnFamilyIDDefault = 0,
- kColumnFamilyIDMetadata,
- kColumnFamilyIDZSetScore,
- kColumnFamilyIDPubSub,
- kColumnFamilyIDPropagate,
- kColumnFamilyIDStream,
- kColumnFamilyIDSearch,
-};
-
enum DBOpenMode {
kDBOpenModeDefault,
kDBOpenModeForReadOnly,
kDBOpenModeAsSecondaryInstance,
};
-namespace engine {
+enum class ColumnFamilyID : uint32_t {
+ PrimarySubkey = 0,
+ Metadata,
+ SecondarySubkey,
+ PubSub,
+ Propagate,
+ Stream,
+ Search,
+};
-constexpr const char *kPubSubColumnFamilyName = "pubsub";
-constexpr const char *kZSetScoreColumnFamilyName = "zset_score";
-constexpr const char *kMetadataColumnFamilyName = "metadata";
-constexpr const char *kSubkeyColumnFamilyName = "default";
-constexpr const char *kPropagateColumnFamilyName = "propagate";
-constexpr const char *kStreamColumnFamilyName = "stream";
-constexpr const char *kSearchColumnFamilyName = "search";
+constexpr uint32_t kMaxColumnFamilyID = 6;
Review Comment:
Use `static_cast<uint32_t>(Search)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
