PragmaTwice commented on code in PR #2317:
URL: https://github.com/apache/kvrocks/pull/2317#discussion_r1603439211
##########
src/server/server.cc:
##########
@@ -808,9 +808,13 @@ void Server::cron() {
// In order to properly handle all possible situations on rocksdb, we
manually resume here
// when encountering no space error and disk quota exceeded error.
if (counter != 0 && counter % 600 == 0 &&
storage->IsDBInRetryableIOError()) {
- storage->GetDB()->Resume();
- LOG(INFO) << "[server] Schedule to resume DB after retryable IO error";
- storage->SetDBInRetryableIOError(false);
+ rocksdb::Status status = storage->GetDB()->Resume();
+ if (status.ok()) {
+ LOG(WARNING) << "[server] Successfully resumed DB after retryable IO
error: " << status.ToString();
Review Comment:
```suggestion
LOG(WARNING) << "[server] Successfully resumed DB after retryable IO
error.";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
