jackyyyyyssss commented on PR #2323: URL: https://github.com/apache/kvrocks/pull/2323#issuecomment-2122174748
> There are several issues in this implemetation: > > * the result of `as_string().size()` is not equal to the real size, we should at least use `to_string()` > * but actually `to_string` is also wrong, since it maybe not equal to the result of `compact_json_string_encoder`. also it would be totally wrong if CBOR format is enabled. > * there may be multiple location found from one jsonpath, which is not handled in this impl > * if jsonpath is `$`, no json decoding is required Thank you for your help. The modifications have been completed, please help me take a look again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
