git-hulk commented on code in PR #2334: URL: https://github.com/apache/kvrocks/pull/2334#discussion_r1616083878
########## src/commands/error_constants.h: ########## @@ -43,5 +43,7 @@ inline constexpr const char *errValueIsNotFloat = "value is not a valid float"; inline constexpr const char *errNoMatchingScript = "NOSCRIPT No matching script. Please use EVAL"; inline constexpr const char *errUnknownOption = "unknown option"; inline constexpr const char *errUnknownSubcommandOrWrongArguments = "Unknown subcommand or wrong number of arguments"; +inline constexpr const char *errWrongNumArguments = "ERR wrong number of arguments"; Review Comment: We cannot remove the ERR prefix since it may introduce a compatibility issue. > Seems some str has Err, some are not.. It's an old implementation issue, Redis uses ERR/LOADING/NOPROTO to identify different kinds of errors, but we didn't take care of this in the original implementation. So it's really hard to fix them in a short time. refer: https://redis.io/docs/latest/develop/reference/protocol-spec/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
