LindaSummer commented on code in PR #2352:
URL: https://github.com/apache/kvrocks/pull/2352#discussion_r1623493510
##########
src/types/redis_stream.cc:
##########
@@ -339,20 +339,36 @@ rocksdb::Status Stream::DeletePelEntries(const Slice
&stream_name, const std::st
WriteBatchLogData log_data(kRedisStream);
batch->PutLogData(log_data.Encode());
+ std::map<std::string, uint64_t> consumer_acknowledges;
for (const auto &id : entry_ids) {
std::string entry_key = internalPelKeyFromGroupAndEntryId(ns_key,
metadata, group_name, id);
std::string value;
s = storage_->Get(rocksdb::ReadOptions(), stream_cf_handle_, entry_key,
&value);
if (s.ok()) {
*acknowledged += 1;
batch->Delete(stream_cf_handle_, entry_key);
+
+ // increment ack for each related consumer
+ auto pel_entry = decodeStreamPelEntryValue(value);
+ consumer_acknowledges[pel_entry.consumer_name]++;
}
}
if (*acknowledged > 0) {
StreamConsumerGroupMetadata group_metadata =
decodeStreamConsumerGroupMetadataValue(get_group_value);
group_metadata.pending_number -= *acknowledged;
std::string group_value =
encodeStreamConsumerGroupMetadataValue(group_metadata);
batch->Put(stream_cf_handle_, group_key, group_value);
+
+ for (const auto &consumer : consumer_acknowledges) {
+ auto consumer_meta_key = internalKeyFromConsumerName(ns_key, metadata,
group_name, consumer.first);
+ std::string consumer_meta_original;
+ s = storage_->Get(rocksdb::ReadOptions(), stream_cf_handle_,
consumer_meta_key, &consumer_meta_original);
+ if (s.ok()) {
Review Comment:
Got it! I have corrected my wording above.
This function returns `rocksdb::Status` and I think I should return the
status immediately in the function when `!s.ok() && !s.IsNotFound()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
