PragmaTwice commented on PR #2389:
URL: https://github.com/apache/kvrocks/pull/2389#issuecomment-2224327233
Could you fix these clang-tidy issues?
```
/home/runner/work/kvrocks/kvrocks/build/_deps/fmt-src/include/fmt/base.h:1619:3:
error: static_assert failed due to requirement 'formattable_pointer'
"Formatting of non-void pointers is disallowed." [clang-diagnostic-error]
Suppressed 21102 warnings (21069 in non-user code, 32 NOLINT, 1 with check
filters).
Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
Found compiler error(s).
static_assert(formattable_pointer,
^ ~~~~~~~~~~~~~~~~~~~
/home/runner/work/kvrocks/kvrocks/build/_deps/fmt-src/include/fmt/base.h:2002:20:
note: in instantiation of function template specialization
'fmt::detail::make_arg<true, fmt::context, double (double) noexcept, 0>'
requested here
return {{detail::make_arg<NUM_ARGS <= detail::max_packed_args, Context>(
^
/home/runner/work/kvrocks/kvrocks/build/_deps/fmt-src/include/fmt/format.h:4357:28:
note: in instantiation of function template specialization
'fmt::make_format_args<fmt::context, double (double) noexcept,
std::basic_string<char>, 2UL, 0UL, 223ULL, 0>' requested here
return vformat(fmt, fmt::make_format_args(args...));
^
/home/runner/work/kvrocks/kvrocks/src/cluster/slot_migrate.cc:394:33: note:
in instantiation of function template specialization 'fmt::format<double
(&)(double) noexcept, std::basic_string<char> &>' requested here
return {Status::NotOK, fmt::format("failed to iterate keys of slot {}:
{}", slot, err_str)};
^
/home/runner/work/kvrocks/kvrocks/src/cluster/slot_migrate.cc:393:66: error:
use of undeclared identifier 'slot' [clang-diagnostic-error]
LOG(ERROR) << "[migrate] Failed to iterate keys of slot " << slot << ":
" << err_str;
^
/home/runner/work/kvrocks/kvrocks/src/cluster/slot_migrate.cc:394:81: error:
use of undeclared identifier 'slot' [clang-diagnostic-error]
return {Status::NotOK, fmt::format("failed to iterate keys of slot {}:
{}", slot, err_str)};
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
