PokIsemaine commented on code in PR #2389:
URL: https://github.com/apache/kvrocks/pull/2389#discussion_r1676813689
##########
src/storage/batch_extractor.cc:
##########
@@ -279,15 +281,17 @@ rocksdb::Status WriteBatchExtractor::DeleteCF(uint32_t
column_family_id, const S
std::string user_key;
std::tie(ns, user_key) = ExtractNamespaceKey<std::string>(key,
is_slot_id_encoded_);
- if (slot_id_ >= 0 && static_cast<uint16_t>(slot_id_) !=
GetSlotIdFromKey(user_key)) {
+ auto key_slot_id = GetSlotIdFromKey(user_key);
+ if (slot_range_.IsValid() && !slot_range_.Contains(key_slot_id)) {
Review Comment:
Do you think there are any inappropriate examples? Could you please
elaborate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
