PragmaTwice commented on code in PR #2402:
URL: https://github.com/apache/kvrocks/pull/2402#discussion_r1694963798
##########
src/commands/cmd_hash.cc:
##########
@@ -429,6 +430,234 @@ class CommandHRandField : public Commander {
bool no_parameters_ = true;
};
+class CommandFieldExpireBase : public Commander {
+ protected:
+ Status commonParse(const std::vector<std::string> &args, int start_idx) {
+ CommandParser parser(args, start_idx);
+ std::string_view expire_flag, num_flag;
+ uint64_t fields_num = 0;
+ while (parser.Good()) {
+ if (parser.EatEqICaseFlag("FIELDS", num_flag)) {
+ fields_num = GET_OR_RET(parser.template TakeInt<uint64_t>());
+ break;
+ } else if (parser.EatEqICaseFlag("NX", expire_flag)) {
+ field_expire_type_ = HashFieldExpireType::NX;
+ } else if (parser.EatEqICaseFlag("XX", expire_flag)) {
+ field_expire_type_ = HashFieldExpireType::XX;
+ } else if (parser.EatEqICaseFlag("GT", expire_flag)) {
+ field_expire_type_ = HashFieldExpireType::GT;
+ } else if (parser.EatEqICaseFlag("LT", expire_flag)) {
+ field_expire_type_ = HashFieldExpireType::LT;
+ } else {
+ return parser.InvalidSyntax();
+ }
+ }
+
+ auto remains = parser.Remains();
+ auto size = args.size();
+ if (remains != fields_num) {
+ return {Status::RedisParseErr, errWrongNumOfArguments};
+ }
+
Review Comment:
Is `FIELDS 2 NX x y` a valid input?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
