PragmaTwice commented on code in PR #2142:
URL: https://github.com/apache/kvrocks/pull/2142#discussion_r1697232559
##########
src/storage/redis_metadata.h:
##########
@@ -90,8 +92,9 @@ enum RedisCommand {
kRedisCmdLMove,
};
-const std::vector<std::string> RedisTypeNames = {"none", "string",
"hash", "list", "set", "zset",
- "bitmap", "sortedint",
"stream", "MBbloom--", "ReJSON-RL"};
+const std::vector<std::string> RedisTypeNames = {"none", "string",
"hash", "list", "set",
+ "zset", "bitmap",
"sortedint", "stream", "MBbloom--",
+ "ReJSON-RL", "search",
"hyperloglog"};
Review Comment:
ditto (for `"search"`)
##########
src/storage/redis_metadata.h:
##########
@@ -313,3 +316,39 @@ class JsonMetadata : public Metadata {
void Encode(std::string *dst) const override;
rocksdb::Status Decode(Slice *input) override;
};
+
+enum class SearchOnDataType : uint8_t {
+ HASH = kRedisHash,
+ JSON = kRedisJson,
+};
+
+class SearchMetadata : public Metadata {
+ public:
+ SearchOnDataType on_data_type;
+
+ explicit SearchMetadata(bool generate_version = true) :
Metadata(kRedisSearch, generate_version) {}
+
+ void Encode(std::string *dst) const override;
+ rocksdb::Status Decode(Slice *input) override;
+};
+
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
