git-hulk commented on code in PR #2332:
URL: https://github.com/apache/kvrocks/pull/2332#discussion_r1715363170


##########
src/search/hnsw_indexer.h:
##########
@@ -41,16 +41,17 @@ struct HnswNode {
 
   HnswNode(NodeKey key, uint16_t level);
 
-  StatusOr<HnswNodeFieldMetadata> DecodeMetadata(const SearchKey& search_key, 
engine::Storage* storage) const;
+  StatusOr<HnswNodeFieldMetadata> DecodeMetadata(engine::Context& ctx, const 
SearchKey& search_key,

Review Comment:
   oh, yes. What I want to say is to remove this storage in this and following 
methods since we can get the storage via the context.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to