git-hulk commented on code in PR #2494:
URL: https://github.com/apache/kvrocks/pull/2494#discussion_r1721191531
##########
src/commands/cmd_list.cc:
##########
@@ -852,16 +852,16 @@ REDIS_REGISTER_COMMANDS(List,
MakeCmdAttr<CommandBLPop>("blpop", -3, "write no-s
MakeCmdAttr<CommandBRPop>("brpop", -3, "write
no-script", 1, -2, 1),
MakeCmdAttr<CommandBLMPop>("blmpop", -5, "write
no-script", CommandBLMPop::keyRangeGen),
MakeCmdAttr<CommandLIndex>("lindex", 3, "read-only",
1, 1, 1),
- MakeCmdAttr<CommandLInsert>("linsert", 5, "write", 1,
1, 1),
+ MakeCmdAttr<CommandLInsert>("linsert", 5, "write
slow", 1, 1, 1),
MakeCmdAttr<CommandLLen>("llen", 2, "read-only", 1, 1,
1),
MakeCmdAttr<CommandLMove>("lmove", 5, "write", 1, 2,
1),
MakeCmdAttr<CommandBLMove>("blmove", 6, "write", 1, 2,
1),
MakeCmdAttr<CommandLPop>("lpop", -2, "write", 1, 1,
1), //
MakeCmdAttr<CommandLPos>("lpos", -3, "read-only", 1,
1, 1),
MakeCmdAttr<CommandLPush>("lpush", -3, "write", 1, 1,
1),
MakeCmdAttr<CommandLPushX>("lpushx", -3, "write", 1,
1, 1),
- MakeCmdAttr<CommandLRange>("lrange", 4, "read-only",
1, 1, 1),
- MakeCmdAttr<CommandLRem>("lrem", 4, "write
no-dbsize-check", 1, 1, 1),
+ MakeCmdAttr<CommandLRange>("lrange", 4, "read-only
slow", 1, 1, 1),
Review Comment:
```suggestion
MakeCmdAttr<CommandLRange>("lrange", 4, "read-only",
1, 1, 1),
```
##########
src/commands/cmd_list.cc:
##########
@@ -495,6 +494,7 @@ class CommandLInsert : public Commander {
} else {
return {Status::RedisParseErr, errInvalidSyntax};
}
+
Review Comment:
```suggestion
```
##########
src/commands/cmd_list.cc:
##########
@@ -464,7 +464,6 @@ class CommandLRem : public Commander {
if (!parse_result) {
return {Status::RedisParseErr, errValueNotInteger};
}
-
Review Comment:
Revert this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
