mapleFU commented on code in PR #243:
URL: https://github.com/apache/kvrocks-website/pull/243#discussion_r1722754519


##########
docs/supported-commands.md:
##########
@@ -55,126 +55,126 @@
 
 | Command    | Supported OR Not | Since Version | Desc                         
                             |
 | ---------- | ---------------- | ------------- | 
--------------------------------------------------------- |
-| BLPOP      | ✓                | v1.0.0        |                              
                             |
-| BRPOP      | ✓                | v1.0.0        |                              
                             |
-| BRPOPLPUSH | 𐄂                | -             | deprecated                   
                             |
-| LINDEX     | ✓                | v1.0.0        | `O(N)` operation, do not use 
it when the list is too long |
-| LINSERT    | ✓                | v1.0.0        | `O(N)` operation, do not use 
it when the list is too long |
-| LLEN       | ✓                | v1.0.0        |                              
                             |
-| LPOP       | ✓                | v1.0.0        |                              
                             |
-| LPUSH      | ✓                | v1.0.0        |                              
                             |
-| LPUSHX     | ✓                | v1.0.0        |                              
                             |
-| LRANGE     | ✓                | v1.0.0        |                              
                             |
-| LREM       | ✓                | v1.0.0        | `O(N)` operation, do not use 
it when the list is too long |
-| LSET       | ✓                | v1.0.0        |                              
                             |
-| LTRIM      | ✓                | v1.0.0        | `O(N)` operation, do not use 
it when the list is too long |
-| RPOP       | ✓                | v1.0.0        |                              
                             |
-| RPOPLPUSH  | ✓                | v1.0.0        |                              
                             |
-| RPUSH      | ✓                | v1.0.0        |                              
                             |
-| RPUSHX     | ✓                | v1.0.0        |                              
                             |
-| LMOVE      | ✓                | v2.1.0        |                              
                             |
-| BLMOVE     | ✓                | v2.6.0        |                              
                             |
-| LPOS       | ✓                | v2.6.0        |                              
                             |
-| LMPOP      | ✓                | v2.6.0        |                              
                             |
-| BLMPOP     | ✓                | v2.7.0        |                              
                             |
+| BLPOP      | ✓                | v1.0.0        | Removes and returns the 
first element of a list, or blocks until one is available.                      
      |
+| BRPOP      | ✓                | v1.0.0        | Removes and returns the last 
element of a list, or blocks until one is available.                            
 |
+| BRPOPLPUSH | 𐄂                | -             | Pops the last element from a 
list, pushes it to another list, and returns it; blocks until an element is 
available.(DEPRECATED) |
+| LINDEX     | ✓                | v1.0.0        | Returns the element at a 
specified index in a list. (`O(N)` operation, do not use it when the list is 
too long) |
+| LINSERT    | ✓                | v1.0.0        | Inserts an element before or 
after another element in a list. (`O(N)` operation, do not use it when the list 
is too long) |
+| LLEN       | ✓                | v1.0.0        | Returns the length of a 
list.                                                                           
      |
+| LPOP       | ✓                | v1.0.0        | Removes and returns the 
first element of a list.                                                        
      |
+| LPUSH      | ✓                | v1.0.0        | Inserts one or more elements 
at the head of a list.                                                          
 |
+| LPUSHX     | ✓                | v1.0.0        | Inserts an element at the 
head of a list, only if the list exists.                                        
    |
+| LRANGE     | ✓                | v1.0.0        | Returns a range of elements 
from a list.                                                                    
  |
+| LREM       | ✓                | v1.0.0        | Removes elements from a list 
that match a specified value. (`O(N)` operation, do not use it when the list is 
too long) |
+| LSET       | ✓                | v1.0.0        | Sets the value of an element 
in a list by its index.                                                         
 |
+| LTRIM      | ✓                | v1.0.0        | Trims a list to the 
specified range of elements. (`O(N)` operation, do not use it when the list is 
too long)  |
+| RPOP       | ✓                | v1.0.0        | Removes and returns the last 
element of a list.                                                              
 |
+| RPOPLPUSH  | ✓                | v1.0.0        | Removes the last element 
from a list and pushes it onto another list.                                    
     |
+| RPUSH      | ✓                | v1.0.0        | Inserts one or more elements 
at the tail of a list.                                                          
 |
+| RPUSHX     | ✓                | v1.0.0        | Inserts an element at the 
tail of a list, only if the list exists.                                        
    |
+| LMOVE      | ✓                | v2.1.0        | Atomically transfers the 
first/last element of a list to the first/last element of another list.         
     |
+| BLMOVE     | ✓                | v2.6.0        | Blocks and then atomically 
transfers the first/last element of a list to the first/last element of another 
list. |
+| LPOS       | ✓                | v2.6.0        | Returns the index of the 
first matching element in a list.                                               
     |
+| LMPOP      | ✓                | v2.6.0        | Removes and returns the 
first or last element(s) of a list.                                             
      |
+| BLMPOP     | ✓                | v2.7.0        | Blocks and then removes and 
returns the first or last element(s) of a list.                                 
  |
 
 ## Set commands
 
 | Command     | Supported OR Not | Since Version | Desc                        
          |
 | ----------- | ---------------- | ------------- | 
------------------------------------- |
-| SADD        | ✓                | v1.0.0        |                             
          |
-| SCARD       | ✓                | v1.0.0        |                             
          |
-| SDIFF       | ✓                | v1.0.0        |                             
          |
-| SDIFFSTORE  | ✓                | v1.0.0        |                             
          |
-| SINTER      | ✓                | v1.0.0        |                             
          |
-| SINTERCARD  | ✓                | v2.5.0        |                             
          |
-| SINTERSTORE | ✓                | v1.0.0        |                             
          |
-| SISMEMBER   | ✓                | v1.0.0        |                             
          |
-| SMEMBERS    | ✓                | v1.0.0        |                             
          |
-| SMOVE       | ✓                | v1.0.0        |                             
          |
-| SPOP        | ✓                | v1.0.0        | pop members in the order of 
keys      |
-| SRANDMEMBER | ✓                | v1.0.0        | always first N members if 
not changed |
-| SREM        | ✓                | v1.0.0        |                             
          |
-| SUNION      | ✓                | v1.0.0        |                             
          |
-| SUNIONSTORE | ✓                | v1.0.0        |                             
          |
-| SSCAN       | ✓                | v1.0.0        |                             
          |
+| SADD        | ✓                | v1.0.0        | Adds one or more members to 
a set.                                                                          
 |
+| SCARD       | ✓                | v1.0.0        | Returns the number of 
members in a set.                                                               
       |
+| SDIFF       | ✓                | v1.0.0        | Returns the difference 
between sets.                                                                   
      |
+| SDIFFSTORE  | ✓                | v1.0.0        | Stores the difference 
between sets in a destination set.                                              
       |
+| SINTER      | ✓                | v1.0.0        | Returns the intersection of 
sets.                                                                           
 |
+| SINTERCARD  | ✓                | v2.5.0        | Returns the cardinality 
(number of elements) in the intersection of sets.                               
     |
+| SINTERSTORE | ✓                | v1.0.0        | Computes the intersection 
of multiple sets and stores the result in a destination set.                    
   |
+| SISMEMBER   | ✓                | v1.0.0        | Checks if a member is part 
of a set.                                                                       
  |
+| SMEMBERS    | ✓                | v1.0.0        | Returns all the members in 
a set.                                                                          
  |
+| SMOVE       | ✓                | v1.0.0        | Moves a member from one set 
to another.                                                                     
 |
+| SPOP        | ✓                | v1.0.0        | Pop members in the order of 
keys      |
+| SRANDMEMBER | ✓                | v1.0.0        | Returns one or more random 
members from a set without removing them. (always first N members if not 
changed) |
+| SREM        | ✓                | v1.0.0        | Removes one or more members 
from a set.                                                                     
 |

Review Comment:
   I remember this is O(N) in kvrocks now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to