ChrisZMF commented on PR #2499:
URL: https://github.com/apache/kvrocks/pull/2499#issuecomment-2300176785

   > LGTM. But seems no regression tests to guard this manner ..
   
   Unit tests can cover this scenario. The reason why unit test was ineffective 
before is that callback was not registered for the item, which means `config 
set` command did not actually execute in rocksdb. See
   
![image](https://github.com/user-attachments/assets/5c57822c-f2f7-4583-877a-0635c7b7b0e1)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to