mapleFU commented on code in PR #2683:
URL: https://github.com/apache/kvrocks/pull/2683#discussion_r1865121831
##########
src/storage/storage.cc:
##########
@@ -98,6 +98,7 @@ void Storage::CloseDB() {
db_->SyncWAL();
rocksdb::CancelAllBackgroundWork(db_.get(), true);
for (auto handle : cf_handles_) db_->DestroyColumnFamilyHandle(handle);
+ shared_block_cache_->DisownData();
Review Comment:
Should we add another flag for this? Since I don't know CloseDb in testing
or other case would checking leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
