fukua95 commented on code in PR #226:
URL:
https://github.com/apache/kvrocks-controller/pull/226#discussion_r1874928770
##########
store/engine/raft/node.go:
##########
@@ -90,7 +90,6 @@ type Node struct {
var _ engine.Engine = (*Node)(nil)
func New(config *Config) (*Node, error) {
- config.init()
Review Comment:
the initial value of `Raft.config` is in the `config.yaml`, so we don't call
`config.init()` again, this can keeps it consistent with other storage_type
(etcd & zk).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
