torwig commented on code in PR #2783:
URL: https://github.com/apache/kvrocks/pull/2783#discussion_r1949059618
##########
src/cli/main.cc:
##########
@@ -109,7 +109,6 @@ static void InitGoogleLog(const Config *config) {
} else {
FLAGS_log_dir = config->log_dir + "/";
if (config->log_retention_days != -1) {
- google::EnableLogCleaner(std::chrono::hours(24) *
config->log_retention_days);
Review Comment:
We don't need a thin line?
##########
src/cli/main.cc:
##########
@@ -109,7 +109,6 @@ static void InitGoogleLog(const Config *config) {
} else {
FLAGS_log_dir = config->log_dir + "/";
if (config->log_retention_days != -1) {
- google::EnableLogCleaner(std::chrono::hours(24) *
config->log_retention_days);
Review Comment:
We don't need a this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
