LindaSummer opened a new pull request, #2799:
URL: https://github.com/apache/kvrocks/pull/2799

   # Issue
   
   Close #2791
   
   # Proposed Changes
   - implement `tdigest.add` command.
   - implement `tdigest.info` command.
   - add integration tests.
   
   # Comment
   
   1. redis `tdigest.info` has one property `Memory usage`, and kvrocks's data 
structure is not in memory, could you give me some suggestions on evaluating 
the memory usage? 😊
   2. in #2620 , we refactor the lock to [outside of the 
command](https://github.com/PokIsemaine/kvrocks/blame/9af83cdcf644915f6d3fa24c7876942f85216cb0/src/server/redis_connection.cc#L493).
   So, I will remove locks after adding "write" property to commands.
   For `quantile` command I plan to use "read" property and manually manage the 
lock to improve performance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to