wyxxxcat commented on code in PR #2803:
URL: https://github.com/apache/kvrocks/pull/2803#discussion_r1971270200


##########
src/types/redis_tdigest.cc:
##########
@@ -147,7 +147,6 @@ rocksdb::Status TDigest::Create(engine::Context& ctx, const 
Slice& digest_name,
 
 rocksdb::Status TDigest::Add(engine::Context& ctx, const Slice& digest_name, 
const std::vector<double>& inputs) {
   auto ns_key = AppendNamespacePrefix(digest_name);
-  LockGuard guard(storage_->GetLockManager(), ns_key);

Review Comment:
   deadlock problem will occur



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to