mapleFU commented on code in PR #2811:
URL: https://github.com/apache/kvrocks/pull/2811#discussion_r1974692000
##########
src/commands/cmd_tdigest.cc:
##########
@@ -168,7 +168,69 @@ class CommandTDigestAdd : public Commander {
std::vector<double> values_;
};
+class CommandTDigestMin : public Commander {
+ public:
+ Status Parse(const std::vector<std::string> &args) override {
+ key_name_ = args[1];
+ return Status::OK();
+ }
+
+ Status Execute(engine::Context &ctx, Server *srv, Connection *conn,
std::string *output) override {
+ TDigest tdigest(srv->storage, conn->GetNamespace());
+ TDigestMetadata metadata;
+ auto s = tdigest.GetMetaData(ctx, key_name_, &metadata);
+ if (!s.ok()) {
+ if (s.IsNotFound()) {
+ return {Status::RedisExecErr, errKeyNotFound};
+ }
+ return {Status::RedisExecErr, s.ToString()};
+ }
+
+ if (metadata.total_observations == 0) {
+ return {Status::RedisExecErr, errValueIsNotExists};
+ }
+
+ *output = redis::BulkString(fmt::format("{}", metadata.minimum));
+ return Status::OK();
+ }
+
+ private:
+ std::string key_name_;
+};
+
+class CommandTDigestMax : public Commander {
+ public:
+ Status Parse(const std::vector<std::string> &args) override {
+ key_name_ = args[1];
+ return Status::OK();
+ }
+
+ Status Execute(engine::Context &ctx, Server *srv, Connection *conn,
std::string *output) override {
+ TDigest tdigest(srv->storage, conn->GetNamespace());
+ TDigestMetadata metadata;
+ auto s = tdigest.GetMetaData(ctx, key_name_, &metadata);
+ if (!s.ok()) {
+ if (s.IsNotFound()) {
+ return {Status::RedisExecErr, errKeyNotFound};
+ }
+ return {Status::RedisExecErr, s.ToString()};
+ }
+
+ if (metadata.total_observations == 0) {
+ return {Status::RedisExecErr, errValueIsNotExists};
Review Comment:
ditto
##########
src/commands/cmd_tdigest.cc:
##########
@@ -168,7 +168,69 @@ class CommandTDigestAdd : public Commander {
std::vector<double> values_;
};
+class CommandTDigestMin : public Commander {
+ public:
+ Status Parse(const std::vector<std::string> &args) override {
+ key_name_ = args[1];
+ return Status::OK();
+ }
+
+ Status Execute(engine::Context &ctx, Server *srv, Connection *conn,
std::string *output) override {
+ TDigest tdigest(srv->storage, conn->GetNamespace());
+ TDigestMetadata metadata;
+ auto s = tdigest.GetMetaData(ctx, key_name_, &metadata);
+ if (!s.ok()) {
+ if (s.IsNotFound()) {
+ return {Status::RedisExecErr, errKeyNotFound};
+ }
+ return {Status::RedisExecErr, s.ToString()};
+ }
+
+ if (metadata.total_observations == 0) {
+ return {Status::RedisExecErr, errValueIsNotExists};
Review Comment:
https://github.com/RedisBloom/RedisBloom/blob/f68a72e463b84c2298990295c6a3db4719dc5c7a/src/rm_tdigest.c#L386
What about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
