git-hulk commented on code in PR #270:
URL:
https://github.com/apache/kvrocks-controller/pull/270#discussion_r1976581921
##########
cmd/server/main.go:
##########
@@ -38,7 +38,7 @@ import (
var configPath string
func init() {
- flag.StringVar(&configPath, "c", "config/config.yaml", "set config yaml
file path")
+ flag.StringVar(&configPath, "c", "config/config-raft.yaml", "set config
yaml file path")
Review Comment:
We could keep `config.yaml` as its default configuration.
##########
config/config-consul.yaml:
##########
@@ -39,4 +39,12 @@ consul:
controller:
failover:
ping_interval_seconds: 3
- min_alive_size: 5
\ No newline at end of file
+ min_alive_size: 5
+
+log:
Review Comment:
Can comment out those lines to keep the stdout as its default output.
##########
config/config-zk.yaml:
##########
@@ -36,4 +36,12 @@ zookeeper:
controller:
failover:
ping_interval_seconds: 3
- min_alive_size: 5
\ No newline at end of file
+ min_alive_size: 5
+
+log:
Review Comment:
The same as above
##########
config/config-raft.yaml:
##########
@@ -42,3 +42,11 @@ controller:
failover:
ping_interval_seconds: 3
min_alive_size: 5
+
+log:
Review Comment:
The same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
