SharonIV0x86 commented on code in PR #2822:
URL: https://github.com/apache/kvrocks/pull/2822#discussion_r1985403099
##########
src/commands/cmd_server.cc:
##########
@@ -1006,12 +1008,42 @@ static uint64_t GenerateConfigFlag(uint64_t flags,
const std::vector<std::string
class CommandLastSave : public Commander {
public:
+ Status Parse(const std::vector<std::string> &args) override {
+ if (args.size() > 2) {
+ return {Status::RedisParseErr, "unknown extra subcommand"};
+ }
+ if (args.size() == 2) {
+ std::string fmt_arg = args[1];
Review Comment:
> You can try to use `EqualICase` (common->string_util.h).
Initially i came across ``parser.EatEqICase()`` but then i dropped the idea
as i didnt know its correct usage so i though i'll take some feedback on its
usage.
Thanks for the review i'll use ``EqualICase`` as it seems a better fit in
this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
