greatsharp commented on code in PR #2823:
URL: https://github.com/apache/kvrocks/pull/2823#discussion_r1986199360
##########
src/stats/log_collector.cc:
##########
@@ -89,6 +101,37 @@ void LogCollector<T>::PushEntry(std::unique_ptr<T> &&entry)
{
entries_.push_front(std::move(entry));
}
+template <>
+void LogCollector<SlowEntry>::PushEntry(std::unique_ptr<SlowEntry> &&entry) {
+ std::lock_guard<std::mutex> guard(mu_);
+ entry->id = ++id_;
+ entry->time = util::GetTimeStamp();
+ if (max_entries_ > 0 && !entries_.empty() && entries_.size() >=
static_cast<size_t>(max_entries_)) {
+ entries_.pop_back();
+ }
+
+ if (slowlog_save_to_logfile_) {
+ std::string cmd;
+ if (entry->args.size() > 0) {
+ for (const auto &arg: entry->args) {
+ cmd.append(arg).append(" ");
+ }
+ cmd.pop_back();
+ }
+ // json format
+ auto log = fmt::format("[slowlog] {{\"id\":{}, \"timestamp\":{},
\"duration\":{}, \"cmd\":\"{}\", "
+ "\"ip\":\"{}\", \"port\":{}, \"client_name\":\"{}\"}}",
+ entry->id, entry->time, entry->duration, cmd, entry->ip, entry->port,
entry->client_name);
Review Comment:
1. just want to show slowlog integrally in log file, distinguish with other
runtime logs.
2. if third-party software wants to gather slowlog from log file, json
format maybe more friendlly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
