SharonIV0x86 opened a new pull request, #2826: URL: https://github.com/apache/kvrocks/pull/2826
This closes #2804 This PR is a Work In Progress and adds the support for the ``TDIGEST.RESET`` command https://redis.io/docs/latest/commands/tdigest.reset/. I’m currently working on implementing the ``TDIGEST.RESET`` command. However, I noticed that there doesn’t seem to be a built-in way to delete centroids from a ``TDigest``. And in order to reset a digest we need to delete the centroids that its containing, correct me if im wrong. Also, to do this, one way i see is that we can manually delete them by iterating over the stored centroids and removing them one by one. Additionally there seems to be already a ``Reset()`` function defined. https://github.com/apache/kvrocks/blob/b8db0e75553ccf6e02cde66c382d86a7d7ec5570/src/types/tdigest.cc#L117 And i am really confused about the two implementation of the ``TDigest`` in kvrocks, one in ``types/redis_tdigest.cc`` and one in ``type/tdigest.cc``. The existing ``TDigest`` commands uses the ``TDigest`` implementation from ``types/redis_tdigest.cc`` and it currently has no ``Reset()`` function defined. So any assistance or reviews on this PR are highly appreciated as i am new to the codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
