Jitmisra commented on code in PR #278:
URL:
https://github.com/apache/kvrocks-controller/pull/278#discussion_r2000594498
##########
store/engine/engine_inmemory.go:
##########
@@ -75,7 +75,7 @@ func (m *Mock) List(_ context.Context, prefix string)
([]Entry, error) {
m.mu.Lock()
defer m.mu.Unlock()
- exists := make(map[string]bool, 0)
+ exists := map[string]bool{}
Review Comment:
Yes this change specifically addresses the issue where a key exactly
matching the prefix wasn’t handled correctly. Regarding the map declaration,
you’re right that both approaches create an empty initialized map, but using
map[string]bool{} is more idiomatic and concise in this case. Let me know if
you have any concerns!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
