LindaSummer commented on code in PR #2826:
URL: https://github.com/apache/kvrocks/pull/2826#discussion_r2002217848
##########
src/cluster/cluster.cc:
##########
@@ -377,7 +377,13 @@ Status Cluster::ImportSlotRange(redis::Connection *conn,
const SlotRange &slot_r
LOG(ERROR) << fmt::format("[import] Failed to stop importing slot(s)
{}: {}", slot_range.String(), s.Msg());
}
}; // Stop forbidding writing slot to accept write commands
- if (slot_range == srv_->slot_migrator->GetForbiddenSlotRange())
srv_->slot_migrator->ReleaseForbiddenSlotRange();
+ if (slot_range.HasOverlap(srv_->slot_migrator->GetForbiddenSlotRange()))
{
Review Comment:
Hi @SharonIV0x86 ,
It seems that this file change should not be shown in this PR.
Could take a review on your commit?
Best Regards,
Edward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
