bseto commented on code in PR #283:
URL:
https://github.com/apache/kvrocks-controller/pull/283#discussion_r2003265397
##########
store/engine/consul/consul.go:
##########
@@ -209,7 +214,7 @@ func (c *Consul) List(ctx context.Context, prefix string)
([]engine.Entry, error
if string(kv.Key) == prefix {
continue
}
- key := strings.TrimLeft(string(kv.Key[prefixLen+1]), "/")
+ key := strings.TrimLeft(string(kv.Key[prefixLen+1:]), "/")
Review Comment:
Bug #2 fix. I noticed that this was missing the `:` which I could find in
the `etcd` and other implementations
##########
store/engine/consul/consul.go:
##########
@@ -209,7 +214,7 @@ func (c *Consul) List(ctx context.Context, prefix string)
([]engine.Entry, error
if string(kv.Key) == prefix {
continue
}
- key := strings.TrimLeft(string(kv.Key[prefixLen+1]), "/")
+ key := strings.TrimLeft(string(kv.Key[prefixLen+1:]), "/")
Review Comment:
Bug 2 fix. I noticed that this was missing the `:` which I could find in the
`etcd` and other implementations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
