torwig commented on code in PR #2838:
URL: https://github.com/apache/kvrocks/pull/2838#discussion_r2005778329
##########
src/search/search_encoding.h:
##########
@@ -40,6 +40,8 @@ class IndexMetadata {
uint8_t flag = 0; // all reserved
IndexOnDataType on_data_type;
+ const std::string &OnDataTypeString() const { return
RedisTypeNames[(size_t)on_data_type]; }
Review Comment:
For me, with the `On` prefix the function sounds like a callback :)
##########
src/storage/redis_metadata.cc:
##########
@@ -222,6 +222,8 @@ bool Metadata::operator==(const Metadata &that) const {
RedisType Metadata::Type() const { return static_cast<RedisType>(flags &
METADATA_TYPE_MASK); }
+const std::string &Metadata::TypeString() const { return
RedisTypeNames[Type()]; }
Review Comment:
`TypeString` => `TypeName`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
