greatsharp opened a new issue, #295:
URL: https://github.com/apache/kvrocks-controller/issues/295

   
https://github.com/apache/kvrocks-controller/blob/e889f364dcd005329edd5ea4071d19b40e9aa13b/controller/cluster.go#L332C1-L333C99
   
   when shard failover, the new master will return empty migration info. it is 
empty too when kvrocks process reboot.
   In these case, controller should clear the old migration info, then user can 
retry.
   
   
   
https://github.com/apache/kvrocks/blob/d6ea22a69fd86ddb0fedd297a550ce02433d4f83/src/cluster/slot_migrate.cc#L1216C1-L1248C2
   `void SlotMigrator::GetMigrationInfo(std::string *info) const {
     info->clear();
     **_if (!slot_range_.load().IsValid() && 
!forbidden_slot_range_.load().IsValid() &&
         !migrate_failed_slot_range_.load().IsValid()) {
       return;
     }_**
   
     SlotRange slot_range;
     std::string task_state;
   
     switch (migration_state_.load()) {
       case MigrationState::kNone:
         task_state = "none";
         break;
       case MigrationState::kStarted:
         task_state = "start";
         slot_range = slot_range_;
         break;
       case MigrationState::kSuccess:
         task_state = "success";
         slot_range = forbidden_slot_range_;
         break;
       case MigrationState::kFailed:
         task_state = "fail";
         slot_range = migrate_failed_slot_range_;
         break;
       default:
         break;
     }
   
     *info = fmt::format("migrating_slot(s): {}\r\ndestination_node: 
{}\r\nmigrating_state: {}\r\n", slot_range.String(),
                         dst_node_, task_state);
   }`
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to