git-hulk commented on code in PR #2881: URL: https://github.com/apache/kvrocks/pull/2881#discussion_r2046665659
########## NOTICE: ########## @@ -71,6 +71,7 @@ The text of each license is also included in licenses/LICENSE-[project].txt * hat-trie(https://github.com/Tessil/hat-trie) * pegtl(https://github.com/taocpp/PEGTL, NOTE: changed to Boost Software License Version 1.0 in main branch) * cpptrace(https://github.com/jeremy-rifkin/cpptrace) +* spdlog(https://github.com/gabime/spdlog) Review Comment: We should remove the `glog` from the NOTICE? ########## src/config/config.cc: ########## @@ -227,7 +221,7 @@ Config::Config() { {"migrate-batch-rate-limit-mb", false, new IntField(&migrate_batch_rate_limit_mb, 16, 0, INT_MAX)}, {"unixsocket", true, new StringField(&unixsocket, "")}, {"unixsocketperm", true, new OctalField(&unixsocketperm, 0777, 1, INT_MAX)}, - {"log-retention-days", false, new IntField(&log_retention_days, -1, -1, INT_MAX)}, + {"log-retention-days", true, new IntField(&log_retention_days, -1, -1, INT_MAX)}, Review Comment: So, `spdlog` cannot change the retention days after initialization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
