ltagliamonte-dd commented on PR #2845: URL: https://github.com/apache/kvrocks/pull/2845#issuecomment-2809406758
@git-hulk is there a method already there I can use to check if the node has replicas? On Wed, Apr 16, 2025, 4:40 AM hulk ***@***.***> wrote: > ***@***.**** approved this pull request. > ------------------------------ > > In src/commands/cmd_server.cc > <https://github.com/apache/kvrocks/pull/2845#discussion_r2046734167>: > > > + } else { > + return {Status::RedisParseErr, "movefiles value must be 'yes' or 'no'"}; > + } > + } else { > + return {Status::RedisParseErr, "unknown option: " + parser.TakeStr().GetValue()}; > + } > + } > + return Commander::Parse(args); > + } > + > + Status Execute([[maybe_unused]] engine::Context &ctx, Server *srv, [[maybe_unused]] Connection *conn, > + std::string *output) override { > + if (srv->GetConfig()->cluster_enabled) { > + return {Status::NotOK, "The SST command is not supported in cluster mode."}; > + } > + if (srv->IsSlave()) { > > Need to disallow if it has any replicas. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/kvrocks/pull/2845#pullrequestreview-2772194919>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AMKKICBXAG2HIR4377ZWVIL2ZY6SBAVCNFSM6AAAAABZQ7GGRGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONZSGE4TIOJRHE> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
