PragmaTwice commented on code in PR #2894:
URL: https://github.com/apache/kvrocks/pull/2894#discussion_r2053231890
##########
src/cluster/replication.cc:
##########
@@ -67,7 +67,7 @@ Status FeedSlaveThread::Start() {
pthread_sigmask(SIG_BLOCK, &mask, &omask);
auto s = util::SockSend(conn_->GetFD(), redis::RESP_OK,
conn_->GetBufferEvent());
if (!s.IsOK()) {
- LOG(ERROR) << "failed to send OK response to the replica: " << s.Msg();
+ error("failed to send OK response to the replica {}", s.Msg());
Review Comment:
```suggestion
error("failed to send OK response to the replica: {}", s.Msg());
```
Why?
##########
src/cluster/replication.cc:
##########
@@ -67,7 +67,7 @@ Status FeedSlaveThread::Start() {
pthread_sigmask(SIG_BLOCK, &mask, &omask);
auto s = util::SockSend(conn_->GetFD(), redis::RESP_OK,
conn_->GetBufferEvent());
if (!s.IsOK()) {
- LOG(ERROR) << "failed to send OK response to the replica: " << s.Msg();
+ error("failed to send OK response to the replica {}", s.Msg());
Review Comment:
```suggestion
error("failed to send OK response to the replica: {}", s.Msg());
```
Why to change the message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
