PragmaTwice commented on issue #2889: URL: https://github.com/apache/kvrocks/issues/2889#issuecomment-2819909983
> I noticed that some of the GLOG calls currently in use haven’t been translated to their spdlog equivalents yet. Do they need to be replaced? [@PragmaTwice](https://github.com/PragmaTwice) GLOG has been removed in kvrocks. Currently `LOG`, `DLOG`, `CHECK`.. are all mocking APIs implemented with spdlog calls. For `DLOG`, I think we can just replace it with `debug()` level logging calls, since from my side logging for only debug-mode build is not so useful (cc @mapleFU @git-hulk). (I actually dislike the idea of `DLOG` itself). For `CHECK` and `DCHECK`, we can keep it as is for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
