git-hulk commented on code in PR #304:
URL:
https://github.com/apache/kvrocks-controller/pull/304#discussion_r2069947492
##########
controller/cluster.go:
##########
@@ -324,10 +324,17 @@ func (c *ClusterChecker) tryUpdateMigrationStatus(ctx
context.Context, clonedClu
log.Error("Failed to get the cluster info from the
source node", zap.Error(err))
return
}
- if sourceNodeClusterInfo.MigratingSlot != shard.MigratingSlot {
+ if sourceNodeClusterInfo.MigratingSlot == nil {
+ log.Error("Source migration slot is nil",
+ zap.String("source_migrating_slot", "nil"),
+ zap.String("migrating_slot",
shard.MigratingSlot.String()),
+ )
Review Comment:
```suggestion
log.Error("The source migration slot is empty",
zap.String("migrating_slot",
shard.MigratingSlot.String()),
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
