jemc commented on issue #2848: URL: https://github.com/apache/kvrocks/issues/2848#issuecomment-2863225475
> You don't need to use `CLUSTERX` command if you're running in HA mode Yes, I know that. The only reason I mentioned it here was after you brought up `kvrocks-controller` and cluster mode. I'm not using cluster mode, so `kvrocks-controller` isn't what I need, nor is the `CLUSTERX` command that it uses to orchestrate `kvrocks`. > And you could just use the redis-sentinel's failover command to switch the role. Changing the state/configuration of redis-sentinel is not helpful/relevant for the specific point raised in this issue ticket. The issue here is that HA KVRocks (appears to?) lack any way to guarantee that acknowledged writes won't be lost during a failover. Redis has a specific command for this (`FAILOVER`) because (at least in Redis), simply switching the master is not enough to make this guarantee. So the scope of this ticket should be to do one of the following for KVRocks: - implement this command or something similar and document it, OR - add documentation that describes how the guarantee is achieved without needing to run any particular command -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
