SharonIV0x86 commented on PR #2849:
URL: https://github.com/apache/kvrocks/pull/2849#issuecomment-2865507078
> @LindaSummer I have added the cpp test case, i believe it needs some
modifications because in the cpp test case its currently not possible to
directly compare the values returned by the quantile function with the "nan"
string as the `result.quantiles` vector is returned empty if the tdigest is
empty. The behaviors differ in the command implementation.
The closest i could do was to add a assert for the value of
``result.has_centroids`` and it should be true and if its found true then it
can be assumed that in the ``Execute`` function of the command implementation
will construct the "nan" strings vector and will return it as a response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
