git-hulk commented on code in PR #310:
URL:
https://github.com/apache/kvrocks-controller/pull/310#discussion_r2083777950
##########
store/cluster_shard.go:
##########
@@ -33,11 +33,18 @@ import (
"github.com/apache/kvrocks-controller/consts"
)
+const (
+ NotMigratingString = "not-migrating"
Review Comment:
We could keep the field null if it's not migrating.
##########
cmd/client/command/helper.go:
##########
@@ -51,8 +51,8 @@ func printCluster(cluster *store.Cluster) {
role = strings.ToUpper(store.RoleMaster)
}
migratingStatus := "NO"
- if shard.MigratingSlot != nil {
- migratingStatus = fmt.Sprintf("%s --> %d",
shard.MigratingSlot, shard.TargetShardIndex)
+ if shard.MigratingSlot.IsMigrating {
+ migratingStatus = fmt.Sprintf("%s --> %d",
&shard.MigratingSlot.SlotRange, shard.TargetShardIndex)
Review Comment:
It should be good without `&`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
