git-hulk commented on code in PR #3001: URL: https://github.com/apache/kvrocks/pull/3001#discussion_r2115971708
########## cmake/jemalloc.cmake: ########## @@ -23,6 +23,15 @@ else() set(DISABLE_CACHE_OBLIVIOUS "--disable-cache-oblivious") endif() +if (NOT DISABLE_JEMALLOC_PROFILING) + set(ENABLE_JEMALLOC_PROFILING "--enable-prof") + # jemalloc profiling is enabled by default, but we can disable it and + # enable it at runtime by setting the environment variable. + set(JEMALLOC_CONFIG_MALLOC_CONF "prof:true,prof_active:false") Review Comment: Oh? I see Jemalloc's configure.ac recognizes this environment, so I would like to test if CMake could pass this. https://github.com/jemalloc/jemalloc/blob/edaab8b3ad752a845019985062689551cd6315c1/configure.ac#L1278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
