git-hulk commented on code in PR #3007:
URL: https://github.com/apache/kvrocks/pull/3007#discussion_r2122564606
##########
src/commands/cmd_server.cc:
##########
@@ -309,6 +309,44 @@ class CommandDBSize : public Commander {
}
};
+class CommandProfiling : public Commander {
+ public:
+ Status Parse(const std::vector<std::string> &args) override {
+ CommandParser parser(args, 1);
+ if (!parser.EatEqICase("memory")) {
+ return {Status::NotOK, "only supports MEMORY subcommand"};
+ }
+ if (parser.EatEqICase("enabled")) {
+ enabled_ = true;
+ } else if (parser.EatEqICase("disabled")) {
+ enabled_ = false;
Review Comment:
Makes sense. I was initially expecting this to be a set status because I
think the verb should be the first word(enable memory profiling).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
