Ryan4253 opened a new pull request, #3012: URL: https://github.com/apache/kvrocks/pull/3012
Closes #3008 ## Description of Changes: EventListener::OnFlushCompleted currently logs the enum directly in the reason field. This commit switches to logging the reason string instead which gives better ergonomics when reading logs. ## Test Plan: ### Unit Test ``` ----------] Global test environment tear-down [==========] 430 tests from 69 test suites ran. (18988 ms total) [ PASSED ] 429 tests. [ SKIPPED ] 1 test, listed below: [ SKIPPED ] UseBitmap/RedisBitmapTest.BitfieldStringGetSetTest/0 ``` ### Logs: Before: ``` [2025-06-03T14:30:37.476414-04:00][I][event_listener.cc:137] [event_listener/flush_completed] column family: metadata, thread_id: 87921, job_id: 11, file: /mnt/rd1isi02/intern/scratch/rliao/kvrocks/compaction/kvrocks/db/000477.sst, reason: 6, is_write_slowdown: no, is_write_stall: no, largest seqno: 15602, smallest seqno: 15256 ``` After: ``` [2025-06-03T10:45:33.144102-04:00][I][event_listener.cc:145] [event_listener/flush_completed] column family: metadata, thread_id: 121487, job_id: 6, file: /mnt/rd1isi02/intern/scratch/rliao/kvrocks/compaction/kvrocks/db/000110.sst, reason: Write Buffer Full, is_write_slowdown: no, is_write_stall: no, largest seqno: 4096, smallest seqno: 3754 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
