nathanlo-hrt opened a new pull request, #3015: URL: https://github.com/apache/kvrocks/pull/3015
Currently `CommandExec` will try and call `CommitTxn` even if the write batch is empty. Also, RocksDB will reject write batch commits on read-only DBs even if they're empty. This means that MULTI/EXEC transactions silently fail: ``` MULTI +OK GET a +QUEUED EXEC *1 -ERR Not implemented: Not supported operation in read only mode. ``` With my change, this will succeed on read-only DBs. ``` MULTI +OK GET a +QUEUED EXEC *1 $1 b ``` and the usual read-only permission checking will still work properly. ``` MULTI +OK SET a b +QUEUED EXEC *1 -ERR Not implemented: Not supported operation in read only mode. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
