git-hulk commented on code in PR #3016:
URL: https://github.com/apache/kvrocks/pull/3016#discussion_r2127799209
##########
kvrocks.conf:
##########
@@ -728,6 +728,13 @@ rocksdb.target_file_size_base 128
# allowed.
rocksdb.max_write_buffer_number 4
+# The minimum number of write buffers that will be merged together
+# during compaction.
+#
+# Default: 2
+rocksdb.min_write_buffer_number_to_merge 2
Review Comment:
Keep the same default value with RocksDB.
```suggestion
# Default: 1
rocksdb.min_write_buffer_number_to_merge 1
```
##########
tests/cppunit/config_test.cc:
##########
@@ -65,6 +65,7 @@ TEST(Config, GetAndSet) {
{"rocksdb.max_open_files", "1234"},
{"rocksdb.write_buffer_size", "1234"},
{"rocksdb.max_write_buffer_number", "1"},
+ {"rocksdb.min_write_buffer_number_to_merge", "2"},
Review Comment:
```suggestion
{"rocksdb.min_write_buffer_number_to_merge", "1"},
```
##########
src/config/config.cc:
##########
@@ -252,6 +252,8 @@ Config::Config() {
{"rocksdb.max_open_files", false, new IntField(&rocks_db.max_open_files,
8096, -1, INT_MAX)},
{"rocksdb.write_buffer_size", false, new
IntField(&rocks_db.write_buffer_size, 64, 0, 4096)},
{"rocksdb.max_write_buffer_number", false, new
IntField(&rocks_db.max_write_buffer_number, 4, 0, 256)},
+ {"rocksdb.min_write_buffer_number_to_merge", false,
+ new IntField(&rocks_db.min_write_buffer_number_to_merge, 4, 1, 256)},
Review Comment:
```suggestion
new IntField(&rocks_db.min_write_buffer_number_to_merge, 1, 1, 256)},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
