Ryan4253 opened a new pull request, #3022:
URL: https://github.com/apache/kvrocks/pull/3022

   Closes #3021 
   
   ## Descrption of Changes:
   Adds a command to flush rocksdb memtables. Users who want to disable WAL and 
want to ensure memtables are flushed would find this useful (current 
alternatives like SIGTERM of shutdown only guarantee that flush happens 
eventually during destruction, rather than being guaranteed with command 
execution)
   
   ## Test Plan:
   ### Unit Test
   ```
   [----------] Global test environment tear-down
   [==========] 429 tests from 69 test suites ran. (20238 ms total)
   [  PASSED  ] 428 tests.
   [  SKIPPED ] 1 test, listed below:
   [  SKIPPED ] UseBitmap/RedisBitmapTest.BitfieldStringGetSetTest/0
   ```
   ### Logs
   #### Redis Client
   ```
   <user>:48081> set a b
   OK
   <user>:48081> flushmemtables wait yes
   OK
   ```
   #### Kvrocks
   ```
   [2025-06-09T16:05:08.507529-04:00][I][event_listener.cc:134] 
[event_listener/flush_begin] column family: metadata, thread_id: 128743, 
job_id: 4, reason: Manual Flush
   [2025-06-09T16:05:08.545747-04:00][I][event_listener.cc:190] 
[event_listener/table_file_created] column family: metadata, file path: 
<path>/kvrocks/db/000104.sst, file size: 1404, job_id: 4, reason: flush, 
status: OK
   [2025-06-09T16:05:08.562556-04:00][I][event_listener.cc:145] 
[event_listener/flush_completed] column family: metadata, thread_id: 128743, 
job_id: 4, file: <path>/kvrocks/db/000104.sst, reason: Manual Flush, 
is_write_slowdown: no, is_write_stall: no, largest seqno: 200004, smallest 
seqno: 200004
   [2025-06-09T16:05:08.566222-04:00][I][cmd_server.cc:1473] flushmemtable was 
triggered by manual with executed success
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to