git-hulk commented on code in PR #318:
URL:
https://github.com/apache/kvrocks-controller/pull/318#discussion_r2144621366
##########
store/cluster_shard.go:
##########
@@ -173,6 +173,11 @@ func (shard *Shard) getNewMasterNodeIndex(ctx
context.Context, masterNodeIndex i
if clusterNodeInfo.Sequence >= newestOffset {
newMasterNodeIndex = i
newestOffset = clusterNodeInfo.Sequence
+
+ // only when the slave nodes's master_link_status is
not up can be selected as the new master
+ if clusterNodeInfo.MasterLinkStatus != "up" {
Review Comment:
@hll1213181368 I realized that we cannot simply filter by the master link
status, because all replicas would be in `down` state if the master node is not
present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
