Genuineh commented on PR #3024:
URL: https://github.com/apache/kvrocks/pull/3024#issuecomment-2975168966

   @git-hulk The real cause of this bug, which resulted from a misunderstanding 
in the previous modification, should be the logical omission in the filtering 
of keys containing slot information under the cluster mode, leading to matching 
issues of keys with different prefixes in the same slot. This submission mainly 
adds the adaptation of matching strategies in related scenarios and relevant 
tests under the cluster environment. Preliminary simple performance tests have 
shown no obvious performance degradation. Due to the lack of a suitable 
performance benchmark testing project, larger-scale performance tests have not 
been carried out. In addition, as I am not familiar with C++, I am not sure 
whether the string allocation and matching strategies are optimal. Please focus 
on this, as string operations may be a performance-consuming part in loops. 
Thank you for your patience. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to