Ryan4253 opened a new issue, #3028:
URL: https://github.com/apache/kvrocks/issues/3028

   ### Search before asking
   
   - [x] I had searched in the 
[issues](https://github.com/apache/kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   Within functions like Server::GetRocksDBInfo there are lines like 
   ```cpp
   db->GetAggregatedIntProperty("rocksdb.size-all-mem-tables", &memtable_sizes);
   ```
   which hard codes the property strings even though RocksDB provides constants 
like ```rocksdb::DB::Properties::kSizeAllMemTables```. This makes code hard to 
trace. 
   
   ### Solution
   
   Use the provided constants
   
   ### Are you willing to submit a PR?
   
   - [x] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to