git-hulk commented on PR #3047: URL: https://github.com/apache/kvrocks/pull/3047#issuecomment-3048074656
> Redis tracks latest write per client, but KVRocks latest write is global. This means WAIT in KVRocks may be less efficient and "over wait", but functionality wise it should be OK. I'm not quite understand this statement. Redis also requires to wait for the number of replica's offset is fulfilled the watermark. And it should not be different with Redis in performance. > Redis replica would ack with the sequence number it has processed. KVRocks is fire and forget style, so when WAIT returns it only guarantees the change has been sent to client, but it does not guarantee client has processed it. This is basically how KVRocks replication works, and I don't think we should touch that for this feature. Redis depends on the `replconf` command to update the replication offset. Kvrocks can also enhance this feature by doing this, but it may need more efforts to achieve this. So I feel good to support the WAIT command with current implementation, and improve it then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
