GitHub user mapleFU added a comment to the discussion: TimeSeries Proposal

(Sorry again for late replying, I'll take a careful pass when I have time, now 
I only have time to read this when I'm not working...) I have a quick first 
scan at the spec, and there're some thoughts:

1. In `Secondary Indexes` part, the key is `key|version`, would this by design 
to hack like this?
2. Assume time series is a write heavy structure, is `firstTimestamp` and 
`endTimestamp` in root meta a good idea? It will update the root and updated 
chunk evertime a write comes. Can we Assume `ts.info` doesn't called 
frequently, and querying it in `chunks` ( this is not a good idea when we have 
too many chunks, this might also requires (3) ), or more hacking, leave `first` 
`end` time stamp for chunks except the last chunk ( which might be frequently 
appending), and querying the last chunk's `end`.
3. I don't know fixed time-window chunk ( I mean, `chunk_id = timestamp // 
chunk_size` , chunk_size=60000ms for minute-level chunks) a good idea. As time 
flies, chunks would be extremly huge. And it's really hard to tunning. 
Personnaly I prefer some internal merging rules to "compact" them, which 
requires a "dynamic" chunking
4. What does `memoryUsage` means in metadata? I think actually it's hard to 
estimate "memoryUsage", since kvrocks currently doesn't have a explicit "cache" 
layer.
5. I don't clear how `Compressed Chunk Type` works, the `ts1 value1 ts2 value2` 
is a bit hacking, why not using `ts1 ts2 ...` for times, and `value1, value2` 
for values? Spliting to one stream might not so good for size-compression ( 
because of data locality ), but might friendly for appending data ( in fact 
`ts1 value1 ts2 value2` with byte-level compression doesn't need to rebuild 
data structure when appending?)

Thanks again for the proposal


GitHub link: 
https://github.com/apache/kvrocks/discussions/3044#discussioncomment-13721299

----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscr...@kvrocks.apache.org

Reply via email to