git-hulk commented on code in PR #3061:
URL: https://github.com/apache/kvrocks/pull/3061#discussion_r2217564014
##########
src/cluster/replication.cc:
##########
@@ -601,14 +658,15 @@ ReplicationThread::CBState
ReplicationThread::incrementBatchLoopCB(bufferevent *
if (!s.IsOK()) {
error("[replication] CRITICAL - Failed to write batch to local, {}.
batch: 0x{}", s.Msg(),
util::StringToHex(batch.Data()));
- return CBState::RESTART;
+ return {CBState::RESTART, data_written};
Review Comment:
I think we don't need to add an extra method and return value, just add a
function like `sendReplConfAck` after applying the write batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
